[11.x] Fix attribute mutator access in loadMissing
#53879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using
->loadMissing
collection method on a nested relationship it can cause all the models in the collection to be converted to JSON which causes attribute mutators to be accessed. This is normally not a problem, unless the mutators need to access other relationships, in which case it can become an issue as certain relationships can get loaded unnecessarily.Proposed Solution
The cause is the use of
->whereNotNull
collection method, which leads to the JSON conversion. The PR changes that bit to a simpler->filter
access.Additional Context
Backtrace when using
->whereNotNull