Add stop() method to Process and Pool #52959
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a process pool:
And I needed to stop all processes in the pool gracefully if they were running.
I was reaching for:
...which didn't exist, so I decided to add it.
We already have
$this->pool->signal(...)
, but the Symfonystop()
method adds some additional logic to ensure that the process is gracefully shut down (if possible): https://github.com/symfony/process/blob/7.1/Process.php#L908-L935There doesn't seem to be any relevant test cases to add here, the main thing is the actual logic if
stop()
which is covered by https://github.com/symfony/process/blob/7.1/Tests/ProcessTest.php#L130