Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow recursive Model::withoutTimestamps calls #52768

Merged
merged 3 commits into from
Sep 12, 2024
Merged

allow recursive Model::withoutTimestamps calls #52768

merged 3 commits into from
Sep 12, 2024

Conversation

m1guelpf
Copy link
Contributor

Should fix the issue @nunomaduro experienced here

@taylorotwell taylorotwell merged commit 54cf9db into laravel:11.x Sep 12, 2024
31 checks passed
@m1guelpf m1guelpf deleted the without-timestamp-recursion branch September 12, 2024 18:12
@nunomaduro
Copy link
Member

@m1guelpf you think you can add a few more tests; specially testing when that static call is done on different models like so?

User::without…
 Model::without…
  Model::without…
   Article::without…
    Article::without…
     User::without…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants