Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] add lazy default to when helper #52747

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[11.x] add lazy default to when helper #52747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02f2c23
add lazy default to when helper
rodrigopedra Sep 11, 2024
ab00d61
Update helpers.php
taylorotwell Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/Illuminate/Collections/helpers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,18 +239,19 @@ function value($value, ...$args)

if (! function_exists('when')) {
/**
* Output a value if the given condition is true.
* Return a value if the given condition is true.
*
* @param mixed $condition
* @param \Closure|mixed $output
* @param \Closure|mixed $value
* @param \Closure|mixed $default
* @return mixed
*/
function when($condition, $output)
function when($condition, $value, $default = null)
{
if ($condition) {
return value($output);
return value($value, $condition);
}

return null;
return value($default, $condition);
Comment on lines -251 to +255
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just

return value($condition ? $value : $default, $condition);

?

}
}
18 changes: 13 additions & 5 deletions tests/Support/SupportHelpersTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,15 +103,23 @@ public function testClassBasename()
public function testWhen()
{
$this->assertEquals('Hello', when(true, 'Hello'));
$this->assertEquals(null, when(false, 'Hello'));
$this->assertNull(when(false, 'Hello'));
$this->assertEquals('There', when(1 === 1, 'There')); // strict types
$this->assertEquals('There', when(1 == '1', 'There')); // loose types
$this->assertEquals(null, when(1 == 2, 'There'));
$this->assertEquals(null, when('1', fn () => null));
$this->assertEquals(null, when(0, fn () => null));
$this->assertNull(when(1 == 2, 'There'));
$this->assertNull(when('1', fn () => null));
$this->assertNull(when(0, fn () => null));
$this->assertEquals('True', when([1, 2, 3, 4], 'True')); // Array
$this->assertEquals(null, when([], 'True')); // Empty Array = Falsy
$this->assertNull(when([], 'True')); // Empty Array = Falsy
$this->assertEquals('True', when(new StdClass, fn () => 'True')); // Object
$this->assertEquals('World', when(false, 'Hello', 'World'));
$this->assertEquals('World', when(1 === 0, 'Hello', 'World')); // strict types
$this->assertEquals('World', when(1 == '0', 'Hello', 'World')); // loose types
$this->assertNull(when('', fn () => 'There', fn () => null));
$this->assertNull(when(0, fn () => 'There', fn () => null));
$this->assertEquals('False', when([], 'True', 'False')); // Empty Array = Falsy
$this->assertTrue(when(true, fn ($value) => $value, fn ($value) => ! $value)); // lazy evaluation
$this->assertTrue(when(false, fn ($value) => $value, fn ($value) => ! $value)); // lazy evaluation
}

public function testFilled()
Expand Down