[11.x] fix: Request::json() json errors when decoding empty string #52204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
changed the title
|
Thanks! |
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I finally tracked down the root cause for the existing json errors in #52188.
When a FormRequest is resolved from the container it calls the
FormRequest::createFrom()method with theRequestobject that, among other things, sets the FormRequest json from the Request json.In the case where the Request does not have any content the
Request::json()method is trying to decode an empty string as an associative array which results in a json syntax error.This PR fixes that error by converting the empty string to an empty json array before decoding.
Thanks!