[11.x] Introduce Str::chopStart and Str::chopEnd

[timacdonald]

This PR introduces a two new string helper functions.

Str::chopEnd('path/to/file.php', '.php');

// "path/to/file"

Str::chopStart('https://laravel.com', ['https://', 'http://']);

// laravel.com

The "chop" methods will only ever chop once and only if the given string exists at the right end of the haystack:

Str::chopStart('https://www.laravel.com', ['https://', 'www.']);

// www.laravel.com

Similar functionality can be achieved with replaceEnd and replaceStart:

Str::replaceEnd('.php', '', 'path/to/file.php');

However, in the case of normalising URLs it becomes more verbose:

Str::of($url)->replaceStart('https://', '')->replaceStart('http://', '');

// compared to...

Str::chopStart($url, ['https://', 'http://']);

I feel this start / end normalization pattern is a common enough pattern that a dedicated method is a nice affordance, even with the tools already at our disposal (those above and regex).

[MrPunyapal]

1.x 👀

[SjorsO]

An extra parameter that makes these methods case-insensitive might be useful too

Also, my first instinct was that these new methods are identical to Str::after() and Str::beforeLast(), but that isn't true:

// Identical in this example:
Str::chopEnd('path/to/file.php', '.php') // path/to/file
Str::beforeLast('path/to/file.php', '.php') // path/to/file

// Not identical in this example:
Str::chopEnd('path/to/file.php.tar.gz', '.php') // path/to/file.php.tar.gz
Str::beforeLast('path/to/file.php.tar.gz', '.php') // path/to/file

[jasonmccreary]

A few suggestions.

First, issue a PR to fix the bug instead of having a bug fix and new feature in the same PR. That way a patch can be released sooner.

Second, while I love chop* methods, is it possible to update the replace*methods to accept an array of searches and potentially default the replacement (empty string). To your points, this would achieve the same thing with existing methods.

For example:

Str::of($url)->replaceStart(['https://', 'http://']);

[timacdonald]

I didn’t like adding this behaviour to replaceEnd / repaceStart because PHP’s native str_replace accepts an array and replaces all of the things in the array. If replace* was to accept an array I would think it would work in the same way, e.g.,

Str::replaceStart(['https://', 'www.'], '', 'https://www.laravel.com']);

// laravel.com

It also has addditional behavior when the haystack is an array, which would have to be something else to consider. The static methods also have the replacement as the middle parameter, unlike the class based API.

I felt a more specific and dedicated method was clearer.

Edit: After chatting with you, I've removed the generator command fix and will leave that for you revert.