Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fixes doc block in Connector.php #51440

Merged
merged 1 commit into from
May 17, 2024

Conversation

saMahmoudzadeh
Copy link
Contributor

This PR, fixes doc block in tryAgainIfCausedByLostConnection method.

The @throws \Exception has been changed to @throws \Throwable, which seems more appropriate, as the parameter $e is of type Throwable.

Additionally, Exception itself extends Throwable.

// Before
* @throws \Exception
*/
protected function tryAgainIfCausedByLostConnection(Throwable $e, $dsn, $username, $password, $options)

// After
* @throws \Throwable
*/
protected function tryAgainIfCausedByLostConnection(Throwable $e, $dsn, $username, $password, $options)

@driesvints driesvints merged commit 46d2c39 into laravel:11.x May 17, 2024
30 checks passed
@driesvints
Copy link
Member

Thanks!

@saMahmoudzadeh saMahmoudzadeh deleted the fix/connector branch May 17, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants