Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Fix apa on non ASCII characters #51428

Merged
merged 5 commits into from
May 16, 2024
+17 −4
Merged

[10.x] Fix apa on non ASCII characters #51428

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
568d7ff
fix apa on accented words
faissaloux May 16, 2024
97485e7
fix code style
faissaloux May 16, 2024
2b2593f
add more tests to apa with more characters
faissaloux May 16, 2024
410991f
fix code style
faissaloux May 16, 2024
38079de
remove empty line
faissaloux May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
remove empty line
@faissaloux
faissaloux committed May 16, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 38079de97a567bc4ae1988084d12fa5a3426a10b
1 change: 0 additions & 1 deletion tests/Support/SupportStrTest.php
View file
Original file line number Diff line number Diff line change
@@ -108,7 +108,6 @@ public function testStringApa()
$this->assertSame('Устное Слово – Не Воробей. Как Только Он Вылетит, Его Не Поймаешь.', Str::apa('устное слово – не воробей. как только он вылетит, его не поймаешь.'));
$this->assertSame('Устное Слово – Не Воробей. Как Только Он Вылетит, Его Не Поймаешь.', Str::apa('Устное Слово – Не Воробей. Как Только Он Вылетит, Его Не Поймаешь.'));
$this->assertSame('Устное Слово – Не Воробей. Как Только Он Вылетит, Его Не Поймаешь.', Str::apa('УСТНОЕ СЛОВО – НЕ ВОРОБЕЙ. КАК ТОЛЬКО ОН ВЫЛЕТИТ, ЕГО НЕ ПОЙМАЕШЬ.'));


$this->assertSame('', Str::apa(''));
$this->assertSame(' ', Str::apa(' '));