Revert " [11.x] Allow adding array or string for web and api routes in bootstrap/app.php" #51407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n bootst…" This reverts commit 78e3dce.
Jacobs63
reviewed
May 14, 2024
Comment on lines
-185
to
-186
| protected function buildRoutingCallback(array|string|null $web = null, | ||
| array|string|null $api = null, |
There was a problem hiding this comment.
Wouldn't just removing these default values fix the issue?
The funcionality seems useful, I believe fixing it like that should be okay?
There was a problem hiding this comment.
I thought these defaults were essential for that PR to work. I could be mistaken.
|
I'll just remove those defaults. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #51356