Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] feat: use phpredis 6 in ci #51347

Merged
merged 1 commit into from
May 9, 2024
Merged

[11.x] feat: use phpredis 6 in ci #51347

merged 1 commit into from
May 9, 2024

Conversation

calebdw
Copy link
Contributor

@calebdw calebdw commented May 8, 2024

Hello!

This updates the ci tests workflow to use phpredis 6 instead of 5.7.3.

Thanks!

Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe testing on 5.3.7 was intentional, to ensure we work with the older extension.

@calebdw
Copy link
Contributor Author

calebdw commented May 9, 2024

@GrahamCampbell, I'm sure it was intentional---the real question is when to move to phpredis 6?

The phpredis 6 version has been out for almost a year and it the version that is installed when users execute:

pecl install phpredis

By moving to v6 this ensures that we continue to work with the newer version which is what users will be installing by default. If v6 was running in ci then this would have already been caught: #51346

However, I have no issues if y'all decide to stick with 5.7.3 and close this PR---I don't have the whole backstory on the decision to continue supporting 5.7.3, but I'm just trying to help :)

@taylorotwell taylorotwell merged commit 892da9e into laravel:11.x May 9, 2024
30 checks passed
@calebdw calebdw deleted the redis branch May 9, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants