[10.x] Move ShouldBeUnique locking from PendingDispatch to Dispatcher #50381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dispatching jobs through the dispatcher directly, the ShouldBeUnique logic isn't checked and the job won't be locked. This is strange undocumented behaviour imo and caused lots of bugs around our platform as we heavily rely on dependency injecting the Dispatcher class. I've seen other instances online where users also dispatch jobs directly on the Dispatcher and I feel like key logic like ShouldBeUnique should be implemented on this level as well as theres no added value to doing so on PendingDispatch level. This even feels kindof hacky to be implemented on PendingDispatch level.