[11.x] Add function to validate if a lock is owned by the current owner. #49249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you just make |
|
Since this doesnt change the contract anymore, would it be ok for you if I change the target to 10.x? |
|
I don't have a big problem with this being sent back to 10.x in this case. Thanks. |
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a public function isOwner to the Cache/Lock.php class and the Contracts/Cache/Lock class. This can be used to determine if a restored lock is owned by the current owner. Currently it is not possible to determine if a restoredLock is owned by the given owner, except when releasing it.
We ran into a problem when we wanted to validate on the queue if we still had the lock on a specific key. We pass the $owner to the job, and can currently release the lock using restoreLock($key, $owner)->release(), but we have no way of validating whether the lock is still viable (without releasing it).