Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] PHPUnit 11 Forward Compatibility #48796

Merged
merged 16 commits into from
Oct 26, 2023
Merged

[11.x] PHPUnit 11 Forward Compatibility #48796

merged 16 commits into from
Oct 26, 2023

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Oct 23, 2023 •
edited
Loading

  • Remove PHPUnit docblock annotation and replace with PHP Attributes.

The following has been done in 10.x via #48815 :

crynobone and others added 6 commits October 23, 2023 17:48
@crynobone
wip
f753541 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
d47662a 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@StyleCIBot
Apply fixes from StyleCI
15f524b
@crynobone
wip
2771ea7 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
wip
124496d 
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@StyleCIBot
Apply fixes from StyleCI
2fede3f
@driesvints driesvints changed the title PHPUnit 11 Compatibility [11.x] PHPUnit 11 Compatibility Oct 24, 2023
crynobone
crynobone commented Oct 24, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@GrahamCampbell
Copy link
Member

I would prefer to see just supporting PHPUnit 10 on Laravel 11, and PHPUnit 11 on Laravel 12, etc, giving us the much more stable and final versions of PHPUnit in each case.

@crynobone
Copy link
Member Author

crynobone commented Oct 26, 2023 •
edited
Loading

Everything in this PR still will work fine with PHPUnit 10.x, we can't/shouldn't send annotation to attribute changes to 10.x because it still supports both PHPUnit 9.x and 10.x

@crynobone crynobone changed the title [11.x] PHPUnit 11 Compatibility [11.x] PHPUnit 11 Forward Compatibility Oct 26, 2023
@crynobone crynobone marked this pull request as ready for review October 26, 2023 10:38
@GrahamCampbell
Copy link
Member

OK, this is better now that it doesn't actually use PHPUnit 11. ;)

@taylorotwell taylorotwell merged commit eb8b176 into master Oct 26, 2023
15 checks passed
@taylorotwell taylorotwell deleted the phpunit11-compatibility branch October 26, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crynobone @GrahamCampbell @driesvints @taylorotwell @StyleCIBot