Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Revival of the reverted changes in 10.25.0: firstOrCreate updateOrCreate improvement through createOrFirst + additional query tests #48637

Merged
merged 25 commits into from
Oct 12, 2023
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
7d793e4
Revert "[10.x] Revert from using `createOrFirst` in other `*OrCreate`…
mpyw Oct 5, 2023
495db28
test: 💍 Add `Builder::createOrFirst()` snapshot tests
mpyw Oct 5, 2023
ebc9ba1
test: 💍 Add `Builder::firstOrCreate()` snapshot tests
mpyw Oct 5, 2023
1eb9b1a
test: 💍 Add `Builder::updateOrCreate()` snapshot tests
mpyw Oct 5, 2023
ff45877
test: 💍 Add test stubs for `DatabaseEloquentHasManyTest`
mpyw Oct 5, 2023
9dad517
test: 💍 Add `HasMany::createOrFirst()` snapshot tests
mpyw Oct 5, 2023
de4c48c
test: 💍 Add `HasMany::firstOrCreate()` snapshot tests
mpyw Oct 5, 2023
1b2620c
test: 💍 Add `HasMany::updateOrCreate()` snapshot tests
mpyw Oct 5, 2023
02b1180
test: 💍 prepare HasManyThrough test
fuwasegu Oct 6, 2023
08beb98
test: 💍 Add HasManyThrough::CreateOrFirst() snapshot tests
fuwasegu Oct 6, 2023
b91d6e8
test: 💍 Add HasManyThrough::firstOrCreate() snapshot test
fuwasegu Oct 6, 2023
eee246b
test: 💍 Add HasManyThrough::updateOrCreate() snapshot test
fuwasegu Oct 6, 2023
15e8999
refactor: 💡 use createOrFirst in firstOrCreate
fuwasegu Oct 6, 2023
b79c5f0
test: 💍 fix test
fuwasegu Oct 6, 2023
7add83e
Merge pull request #1 from fuwasegu/test/has-many-through
mpyw Oct 6, 2023
30d4627
style: 💄 Apply StyleCI fixes
mpyw Oct 6, 2023
f42cd8b
docs: ✏️ Add missing FIXME comments
mpyw Oct 6, 2023
be2f795
refactor: 💡 Omit verbose arguments
mpyw Oct 6, 2023
77f2311
test: 💍 Rename `DatabaseEloquentHasManyThroughTest` with fixes
mpyw Oct 6, 2023
640d39c
test: 💍 Add `BelongsToMany::createOrFirst/firstOrCreate` tests
mpyw Oct 6, 2023
2935602
test: 💍 Extract `DatabaseEloquentHasManyTest` cases with fixes
mpyw Oct 6, 2023
2419b1c
test: 💍 Extract `DatabaseEloquentBuilderTest` cases with fixes
mpyw Oct 6, 2023
4cefa9c
test: 💍 refactoring
mpyw Oct 6, 2023
fab4ee3
test: 💍 Add `BelongsToMany::updateOrCreate` snapshot tests
mpyw Oct 6, 2023
19f8b61
Merge remote-tracking branch '10.x' into feat/create-or-first-optimiz…
mpyw Oct 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: 💄 Apply StyleCI fixes
mpyw committed Oct 6, 2023

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tvdeyen Thomas von Deyen
commit 30d462774960f925e58c33293c077d605cfb9b3d
1 change: 0 additions & 1 deletion tests/Database/DatabaseEloquentHasManyThroughTest.php
Original file line number Diff line number Diff line change
@@ -405,4 +405,3 @@ public function children(): HasManyThrough
);
}
}