[10.x] Use the dedicated key getters in BelongsTo #48509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I mark it as draft until I update the tests to properly handle this. The |
timacdonald
pushed a commit
to timacdonald/framework
that referenced
this pull request
Sep 27, 2023
* [10.x] Use the dedicated key getters in BelongsTo * fix method call * Update tests * fix style ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to customize the resolution of the owner and foreign keys. However in the
matchmethod the code uses the keys directly, so the custom getters would not have any effect.Related PR: #47378