-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.x] Add mariadb to databases config #48455
[11.x] Add mariadb to databases config #48455
Conversation
Any ideas why the MariaDB 10 tests fail? I can't find a location were I missed adding |
@@ -140,7 +140,7 @@ jobs: | |||
- name: Execute tests | |||
run: vendor/bin/phpunit tests/Integration/Database | |||
env: | |||
DB_CONNECTION: mysql | |||
DB_CONNECTION: mariadb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taylorotwell these are the mariadb tests and previously it used the mysql connection. Now it uses its dedicated mariadb connection which this PR creates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that the MariaDB Database tests are run against the MariaDB configuration instead of the MySQL configuration. Because of the changed collation in the mysql configuration which does not exist in MariaDB, this would throw an error.
This should be expected since Testbench holds it's own configuration files. |
I forget about Testbench. Thanks! |
Hi @Jubeki / @driesvints Now that we'll have a dedicated config for MariaDB, shouldn't the default collation for MariaDB be
Note that I used What do you think about it ? |
@Tristan-MyAnaPro this seems like a good idea. Probably as of MariaDB 11.4. See https://jira.mariadb.org/browse/MDEV-19123 |
b70ebc8
to
d8f44e3
Compare
31a0985
to
bb53692
Compare
@Jubeki are you still working on this one? |
@driesvints in my opinion I am finished with this PR. I only rebase against One point for discussion open is only:
(Taylor put the PR into Draft, so I left it like that) |
d8f44e3
to
55513c9
Compare
bb53692
to
9659479
Compare
55513c9
to
ae53dbc
Compare
Note - MDEV-32336 deb default config - use collation-server = utf8mb4_uca1400_ai_ci MariaDB/server#2775 for 11.3 That without an explicit collation utf8mb4 uses the collation uca1400_ai_ci. Applying this to Debian/Ubuntu will flow through to the mariadb:11.3 container on the next release. If you want to ensure that the next version of MariaDB (server and container) to be released is going to be Laravel compatible (and give you a chance to tell MariaDB to fix things before release :-) ) you can use the following container images:
These are the latest version of completed code merged into the main branches - https://quay.io/repository/mariadb-foundation/mariadb-devel?tab=tags . The code there has passed review and is expected to work so this isn't a beta tree, just an unreleased version. information:
Or just ask me. Happy to help. |
@Jubeki we might want to resend in this PR as Taylor probably force-pushed his commits. |
9659479
to
15afe53
Compare
@grooverdan Thanks for the information about the changes in MariaDB. I applied the default collation in the config accordingly. I don't think the newer container image is needed here, because the tested mariadb version already supports the new collation, but of course the Laravel Team can decide to test against the new image. (FYI Laravel 11 will probably be released in February 2024 as far as I know). @driesvints I rebased against |
@Jubeki yeah go for it |
220e722
into
laravel:slim-skeleton-11.x
* Add MariaDB to databases config and Change MySQL 8 collation * Update tests workflow for MariaDB * Update default collation for mariadb
GitHub actions throws exceptions for unkown utf8mb4_0900_ai_ci which is the new default in Laravel 11. laravel/framework#48455
GitHub actions throws exceptions for unkown utf8mb4_0900_ai_ci which is the new default in Laravel 11. laravel/framework#48455
GitHub actions throws exceptions for unkown utf8mb4_0900_ai_ci which is the new default in Laravel 11. laravel/framework#48455
This adds proper support for MariaDB, as the default/recommended collation for mysql and mariadb has changed.
See laravel/laravel#6239
See laravel/laravel#6240
See laravel/laravel#6241
Changes:
utf8mb4_0900_ai_ci
utf8mb4_uca1400_ai_ci
Changes to the config still needs to be applied to Testbench.