Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "resolve" to Component::ignoredMethods() method #48373

Merged

Conversation

ph7jack
Copy link
Contributor

@ph7jack ph7jack commented Sep 13, 2023

Hi everyone,

I've made a minor change to the Illuminate\View\Component class by adding the resolve() method into the ignoredMethods().
This method was introduced in this commit, and I believe it should not be added to the view data.

Changes:

  • Add resolve to Component::ignoredMethods()

Purpose:

  • Remove this data exposure from the blade $data, since it's not a method to be able to call in a blade view

Thank you for considering this PR.

Feel free to adjust the wording as necessary to match your style and the specific changes you've made!

- add a missing internal method to the ignored component methods
@taylorotwell taylorotwell merged commit 5f78beb into laravel:10.x Sep 13, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants