Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Circumvent PHP 8.2.9 date format bug that makes artisan serve crash #47931

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

levu42
Copy link
Contributor

@levu42 levu42 commented Aug 2, 2023

Circumvent PHP 8.2.9 bug that has double whitespace in datetimes for artisan serve. See #47930 for details.

@levu42 levu42 changed the title fix(ServeCommand.php): fixes #47930 Artisan serve: fix for PHP 8.2.9 Aug 2, 2023
@levu42 levu42 changed the title Artisan serve: fix for PHP 8.2.9 [10.x] Circumvent PHP 8.2.9 date format bug that makes artisan serve crash Aug 2, 2023
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is targetted at the wrong branch. Should be 9.x.

@levu42
Copy link
Contributor Author

levu42 commented Aug 2, 2023

@GrahamCampbell it's happening also on Laravel 10.x, which is where I encountered the bug. It might be also happening on 9.x, but I didn't check it there.

@GrahamCampbell
Copy link
Member

GrahamCampbell commented Aug 2, 2023

Bug fixes need to go into the earliest branch that is still maintained for bug fixes. The contribution guide is unfortunately incorrect in that it says 10.x is the right branch for bug fixes - 9.x is still the right branch, at least for the next few days, until 9.x moves out of active support (last release probably next week, then just security releases, as needed).

@levu42 levu42 changed the base branch from 10.x to 9.x August 2, 2023 12:33
@levu42 levu42 changed the title [10.x] Circumvent PHP 8.2.9 date format bug that makes artisan serve crash [9.x] Circumvent PHP 8.2.9 date format bug that makes artisan serve crash Aug 2, 2023
@levu42
Copy link
Contributor Author

levu42 commented Aug 2, 2023

@GrahamCampbell now it should correctly be set up on 9.x :)

@levu42 levu42 requested a review from GrahamCampbell August 2, 2023 12:37
@taylorotwell taylorotwell merged commit e9ad8c3 into laravel:9.x Aug 2, 2023
@GrahamCampbell
Copy link
Member

Thanks. This will go out in the next 9.x, 10.x, and eventually 11.x release. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants