[10.x] Retain $request->request
InputBag
type
#47838
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create the Illuminate request, we set the
$request->request
property to the value of the$request->json
property.Symfony is expecting
$request->request
to be anInputBag
when invoking$request->getPayload()
. See:https://github.com/symfony/symfony/blob/42d9d7cd64c5b9897a2113c12d76c75a8d31ad9c/src/Symfony/Component/HttpFoundation/Request.php#L1514
The
$request->json
property is an instance ofParameterBag
. This is the parent class ofInputBag
.So we are setting
$request->request
to an instance ofParameterBag
instead ofInputBag
which is then breaking due to the return type onRequest::getPayload()
Side note
It is possible that we should make
$request->json
an instance ofInputBag
to make things consistent, however this is a quick fix to fix the framework asap.fixes #47834