[10.x] Support inline disk for scoped driver #47776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbowers
changed the title
|
That SQL Server 2019 failure is strange, not sure how to resolve that. is it a known isuse? |
|
@alexbowers can you rebase? I disabled it for now. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you want to use the
scopeddisk driver, there is a requirement to have a separate disk that is unscoped.If you want to make all of your storage writes in a scoped manner (for example, to customer specific directories), then this requires you to have another
diskthat is configured, that you don't want to ever actually use directly.There is potential for a developer to use the disk inadvertently, or for you to have to mark it as 'hidden' in some way, such as prefixing with an underscore, or similar.
This pull request allows you to optionally declare your disk inline in the scoped driver, so that you don't need to have this additional storage disk, if you only ever want to interact with the scoped driver itself.