[10.x] Narrow down array type for $attributes
in CastsAttributes
#47365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation contains an example with an
array<string, mixed>
type hint for$attributes
, which is more specific thanarray
, as type hinted in the source. However, if I wanted to use the more specific type hint from the example in my application, PHPStan reports the following:So I propose to update the type hint in the source to be consistent with the example in the documentation. Thanks!
Edit: the
make:cast
stub also uses thearray<string, mixed>
type hint.