[10.x] fix Expression string casting
#46137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Expression` class no longer provides a `__toString()` method, so we cannot cast it to a string here. We'll now use the `->getValue()` method and pass the current database connection's query grammar. laravel#44784
crynobone
reviewed
Feb 16, 2023
chu121su12
pushed a commit
to chu121su12/framework
that referenced
this pull request
Feb 25, 2023
The `Expression` class no longer provides a `__toString()` method, so we cannot cast it to a string here. We'll now use the `->getValue()` method and pass the current database connection's query grammar. laravel#44784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Expressionclass no longer provides a__toString()method, so we cannot cast it to a string here.We'll now use the
->getValue()method and pass the current database connection's query grammar.#44784
strangely enough, the
HasInDatabase::toString()method is only called to get the failure description, but I was getting the unavailable string casting error even without a test failure. this leads me to believe PHPUnit is (sometimes) calling thefailureDescription()method even without a failure? Not sure on this.