add AddQueuedCookiesToResponse to middlewarePriority so it is handled in the right place #46130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the right place Hi there, i was trying to set `session storage` to `cookie`, but the cookies were not set at all. after a bit of search, this came up: laravel#43693 and now i know what he meant. the queued cookies (https://github.com/laravel/framework/blob/10.x/src/Illuminate/Session/CookieSessionHandler.php#L101) never got sent back to the browser adding the middleware to the list so it is priority-sorted seems to resolve this issue (and fixes laravel#43693) targets both 9.x and 10.x versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I was trying to set
session storagetocookie, but the cookies with session data were not set at all. After a bit of search, this came up: #43693 and that is a perfect match, the queued cookies (https://github.com/laravel/framework/blob/10.x/src/Illuminate/Session/CookieSessionHandler.php#L101) never got sent back to the browser, because the middleware was handled in the wrong "place"adding the middleware to the list so it is always in correct order seems to resolve this issue (and fixes #43693)
targets both 9.x and 10.x versions