[9.x] Fix decimal cast precision issue #45456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45454
Problem
Currently we are handling floats via
format_number
. Because ofnumber_format
, we are losing precision, if the precision is long enough.Solution
This is a 2 part solution. This PR is part one to address this issue in the least breaking way possible for
9.x
and then a follow up PR will fix this usingbcmath
instead.To solve this for
9.x
we are now manually handling the formatting via theStr
helper.Breaking
number_format
rounds numbers when the precision is being reduced. This is no longer the case and I'm not aware of any good way to handle this.I'm proposing that in
10.x
we change this manual string manipulation into a basicbcmath
call: #45457I feel that making
bcmath
a requirement to use an existing feature could be a breaking change for some applications(?)