[10.x] Adds PHPUnit 10 support #45416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
crynobone
reviewed
Dec 23, 2022
nunomaduro
commented
Dec 28, 2022
nunomaduro
force-pushed
the
feat/phpunit10
branch
from
78e81f5 to
f1fd3d3
Compare
nunomaduro
force-pushed
the
feat/phpunit10
branch
from
f1fd3d3 to
8454004
Compare
nunomaduro
commented
Jan 30, 2023
nunomaduro
force-pushed
the
feat/phpunit10
branch
from
96fd958 to
992ba67
Compare
Co-authored-by: Mior Muhammad Zaki <[email protected]>
nunomaduro
force-pushed
the
feat/phpunit10
branch
from
78a1930 to
9a6d16d
Compare
Comment on lines
119
to
135
| protected function runTest(): mixed | ||
| { | ||
| $result = null; | ||
|
|
||
| try { | ||
| $result = parent::runTest(); | ||
| } catch (Throwable $e) { | ||
| if (! is_null(static::$latestResponse)) { | ||
| static::$latestResponse->transformNotSuccessfulException($e); | ||
| } | ||
|
|
||
| throw $e; | ||
| } | ||
|
|
||
| return $result; | ||
| } | ||
|
|
There was a problem hiding this comment.
For all who are looking for PHPStorm Jump to source fixes because of this update and found my comment - just upgrade your deps to PHPUnit 10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds PHPUnit 10 support to
laravel/framework- while keeping support for PHPUnit 9. Note that this pull request, should test and released once PHPUnit 10 is out. In addition:v7.xoctane#643).composer.jsonwith the latest version of Testbench.