[10.x] Clean up DBAL deprecations #45289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
driesvints
commented
Dec 13, 2022
driesvints
commented
Dec 13, 2022
| class NoPendingMigrations | ||
| use Illuminate\Contracts\Database\Events\MigrationEvent as MigrationEventContract; | ||
|
|
||
| class NoPendingMigrations implements MigrationEventContract |
There was a problem hiding this comment.
For some reason this event didn't have the MigrationEvent contract which seemed odd to me. I can't think of a reason why it shouldn't have this.
driesvints
force-pushed
the
cleanup-dbal
branch
from
d369ee6 to
23fda3c
Compare
driesvints
commented
Dec 13, 2022
| @@ -164,7 +164,7 @@ public function testChangingColumnWithCollationWorks() | |||
| [ | |||
| 'CREATE TEMPORARY TABLE __temp__users AS SELECT age FROM users', | |||
| 'DROP TABLE users', | |||
| 'CREATE TABLE users (age INTEGER NOT NULL COLLATE "NOCASE")', | |||
| 'CREATE TABLE users (age INTEGER NOT NULL)', | |||
There was a problem hiding this comment.
I guess these now will take the default collation.
driesvints
commented
Dec 13, 2022
| 'DROP TABLE users', | ||
| 'CREATE TABLE users (name VARCHAR(255) DEFAULT NULL COLLATE "BINARY")', | ||
| 'INSERT INTO users (name) SELECT name FROM __temp__users', | ||
| 'DROP TABLE __temp__users', |
There was a problem hiding this comment.
It seems DBAL is now smarter here and doesn't creates temporary tables anymore when only a unique constraint or an index is added to the table.
driesvints
force-pushed
the
cleanup-dbal
branch
from
23fda3c to
fff37a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some deprecations from the move to Doctrine DBAL v3 (since we're dropping support for DBAL v2). Most likely these will be removed in Doctrine v4. There's still a couple of left which I haven't determined the right path to migrate to yet. Left some notes on other quirks I found below.