[9.x] Show error if key:generate artisan command fails #44927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@driesvints @mbardelmeijer is there any interest in using something like the Laravel Config Writer provided by @wintercms (see https://github.com/wintercms/laravel-config-writer/blob/main/README.md#environment-files) to more reliably handle these issues rather than just failing? |
|
@LukeTowers appreciate it but I don't think so no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes that if the
artisan key:generatefails, an error message is shown.This is most common when the
.envfile is missing anAPP_KEY=empty placeholder. In this case, thepreg_replacecall will return the input as-is. If that happened, an error is shown instead of showing the incorrectApplication key set successfully.Fixes #44917