Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fixes ensureDependenciesExist runtime error #43626

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

nunomaduro
Copy link
Member

This pull request fixes a small regression introduced on #43367, where installing the necessary composer dependencies for "db:show", "db:table", and "model:show" is not causing the command to terminate, consequentially displays a runtime exception:

Screenshot 2022-08-09 at 18 59 24

With this pull request, when doctrine/dbal is not installed for the current execution, we simply exit the command even if the user decides to install doctrine/dbal. Just like it was before #43367.

Screenshot 2022-08-09 at 19 01 17

@nunomaduro nunomaduro requested a review from taylorotwell August 9, 2022 18:01
@taylorotwell taylorotwell merged commit fdf3ae9 into 9.x Aug 11, 2022
@taylorotwell taylorotwell deleted the fix/ensure-database-inspection-dependencies branch August 11, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants