Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Protect against ambiguous columns #43275

Closed
wants to merge 1 commit into from
Closed

[9.x] Protect against ambiguous columns #43275

wants to merge 1 commit into from

Conversation

BenWalters
Copy link
Contributor

Resolving #43274

@driesvints
Copy link
Member

Tests are failing here.

@driesvints
Copy link
Member

Actually can you send this to 8.x since this is a bug fix?

@driesvints driesvints closed this Jul 19, 2022
@BenWalters
Copy link
Contributor Author

@driesvints sure, I can make the change on 8.x and recreate a PR. Any suggestions on the failing tests? On initial review it seems wrong that the AuthEloquentUserProviderTest should be using a stdClass to test retrieval of an Eloquent User?

@driesvints
Copy link
Member

@BenWalters I don't have too much time to deep dive into this. I guess you'll need to add a mock reference for the new method call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenWalters @driesvints