Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix transaction attempts counter for sqlsrv #43176

Merged

Conversation

krasucki
Copy link
Contributor

This brings back transactions attempts for sqlsrv driver

This brings back transactions attempts for sqlsrv driver
@taylorotwell
Copy link
Member

When was it removed and why?

@krasucki
Copy link
Contributor Author

First introduced in #1883 (well not precisely, because at that time there wasn't $attempts implemented yet, but that was the initial version of this sqlsrv condition) , then during some bug fixing in f4588f8, for some reason the $attempts was omitted. For me it look like mistake, because there is no reason not to re-run transactions for (pdo) sqlsrv driver.

This is interesting because during all that time nobody noticed this (I must admit that driver is not as popular, but still..)

maybe @GrahamCampbell can help here?

@GrahamCampbell
Copy link
Member

The commit you reference does not remove the parameter, but it's possible that not adding it at that point was a mistake.

@GrahamCampbell GrahamCampbell changed the title Fix transaction attempts counter for sqlsrv [8.x] Fix transaction attempts counter for sqlsrv Jul 14, 2022
@GrahamCampbell
Copy link
Member

I think we could go-ahead and merge this, and see if anyone complains.

@taylorotwell taylorotwell merged commit 46cdc3c into laravel:8.x Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants