[8.x] apply where's from union query builder in cursor pagination #42651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the ability to use cursor pagination with union queries.
here's an example:
The specified order for this builder instance is now on
unionOrders
property rather thanorders
. But further down the road insrc/Illuminate/Database/Query/Builder.php
methodensureOrderForCursorPagination
, the order is retrieved fromorders
property, which is null. Within that function, the specified order needs to be retrieved either fromorders
orunionOrders
property, it also needs a filter for orders without direction (type "Raw").Next issue to address is in method
paginateUsingCursor
fromsrc/Illuminate/Database/Concerns/BuildsQueries.php
. It only adds the conditions from the cursor to the main query, not the union query.So instead of
it produces