Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fix assert that exception is thrown without message #42360

Merged
merged 1 commit into from
May 11, 2022

Conversation

shaffe-fr
Copy link
Contributor

@shaffe-fr shaffe-fr commented May 11, 2022

Hi,
This fixes #42155.
With previous implementation, no assertions were made when the specified exception is thrown but no expected message specified leading to the message "This test did not perform any assertions".

Thanks to @christophrumpel for the heads up.

@shaffe-fr shaffe-fr changed the title Assert that exception is thrown without message [9;x] Fix assert that exception is thrown without message May 11, 2022
@shaffe-fr shaffe-fr changed the title [9;x] Fix assert that exception is thrown without message [9.x] Fix assert that exception is thrown without message May 11, 2022
@shaffe-fr shaffe-fr marked this pull request as ready for review May 11, 2022 21:31
@taylorotwell taylorotwell merged commit 6f717ad into laravel:9.x May 11, 2022
@shaffe-fr shaffe-fr deleted the patch-1 branch May 11, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants