Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Remove useless if statement in Str #41570

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

hAz5
Copy link
Contributor

@hAz5 hAz5 commented Mar 19, 2022

because min requirement of Laravel9 PHP version is 8 and above
we don't need to check this

  if (is_null($length) && PHP_MAJOR_VERSION < 8) {
      $length = mb_strlen($string, $encoding);
  }

@hAz5 hAz5 force-pushed the remove-useless-statement branch from c7e1fe5 to 37b6287 Compare March 19, 2022 12:32
@hAz5 hAz5 changed the title [9.x] remove useless if statement [9.x] remove useless if statement in Str Mar 19, 2022
@imanghafoori1
Copy link
Contributor

Please explain why it is useless.

@crynobone
Copy link
Member

Please explain why it is useless.

Laravel 9 doesn't support PHP 7

@taylorotwell taylorotwell merged commit 066eb53 into laravel:9.x Mar 19, 2022
@GrahamCampbell GrahamCampbell changed the title [9.x] remove useless if statement in Str [9.x] Remove useless if statement in Str Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants