[9.x] Make throttle lock acquisition retry time configurable #41516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on context, 750ms can be a long time to wait between retries
for a throttle. We are making the retry time configurable so that users
can tune the throttling further.
All changes are backwards compatible.
I set the unit as milliseconds because this seemed like the natural time
unit to use. Seconds would require floats which felt dirty. That being
said, it's not consistent with the unit used for
->every
and->block
on the builder. So I'm open to changing it for consistency.
I was additionally unsure what useful tests could be written for this
configuration. Mocking the
usleep
function felt silly. Any suggestionsare welcome.