Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fixes getting the trusted proxies IPs from the configuration file #41322

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

nunomaduro
Copy link
Member

This pull request allows getting the trusted proxies IPs from the configuration file, like back in the days when we had Fideloper's package.

@nunomaduro nunomaduro requested a review from taylorotwell March 3, 2022 15:03
@nunomaduro nunomaduro marked this pull request as draft March 3, 2022 15:05
@nunomaduro nunomaduro marked this pull request as ready for review March 3, 2022 15:09
@taylorotwell taylorotwell merged commit 326db93 into 8.x Mar 3, 2022
@taylorotwell taylorotwell deleted the fix/restores-getting-proxies-from-config branch March 3, 2022 15:12
@amenk
Copy link
Contributor

amenk commented Sep 4, 2023

@nunomaduro Did you consider re-adding a default env('TRUSTED_PROXIES') ? This would be helpful in situations where Laravel is hosted in Docker for example and would not required to change the default installation anymore.

We could as well make a pull request if @taylorotwell sees changes to get that accepted?

See also #38974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants