[8.x] Fix database migrations $connection
property
#41161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41153 #40097 #38777 #36596 #31060
The docs show the below migration will be run on the named database connection:
However
Schema
facade-built queries will run on the app's default database connection or the--database
command line option's named connection. The migration also requiresSchema::connection('pgsql')
:This fix allows the first example to work as documented for the
up()
&down()
methods. The selected connection priority is:Schema::connection()
$connection
php artisan migrate*
command line option--database
config('database.default')
I also added tests for the
Migrator@usingConnection()
method added in 7.x for the migration commands.