Update ResetPassword.php #41103
Closed
Update ResetPassword.php #41103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're adding a test that makes the current behavior a requirement. With it, we cannot merge this PR. Please see #41104 |
|
Okey, so you don't think this is a bug? |
|
@zeitlerquintet no. You're free to attempt a PR to master if you want to. |
|
thanks, I'll do so 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
ResetPassword::createUrlUsingwas useless if also
ResetPassword::toMailUsingwas set.
The resetUrl wasn't calculated by the given ResetPassword::createUrlUsing callback and wasn't passed to the ResetPassword::toMailUsing callback.