Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Fix Stringable ucsplit #40694

Merged
merged 1 commit into from
Jan 28, 2022
Merged

[8.x] Fix Stringable ucsplit #40694

merged 1 commit into from
Jan 28, 2022

Conversation

tomirons
Copy link
Contributor

This was passing an array into the constructor which causes an exception. Also, this should be the last method you call on the chain since Str::ucsplit returns an array.

@taylorotwell taylorotwell merged commit 498fdd2 into laravel:8.x Jan 28, 2022
@foremtehan
Copy link
Contributor

What is wrong with returning Collection ?

@tomirons tomirons deleted the patch-3 branch January 28, 2022 16:24
@tomirons tomirons mentioned this pull request Jan 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomirons @foremtehan @taylorotwell