[8.x] Fix autoresolving model name from factory #40616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, a factory can't auto-resolve namespaced models which are nested inside the models directory and have coresponding Factory classes at the same location. You can reproduce this with the issue at #40614
By changing the code here to take into account the nested namespace for factory classes, we can auto resort the model name without having to define the
$model
class on the factory.One thing I'm not sure off is that if we should just fallback on the model classname without the namespace for the last part here (as it was before):
I can adjust the code for that if you like.
Fixes #40614