-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Fix flushdb for predis cluster #40446
[8.x] Fix flushdb for predis cluster #40446
Conversation
Thanks @bernardwiesner! Let's move that logic into the |
@tillkruss |
Please mark as ready for review when all issues have been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@taylorotwell: The fix here will be going from |
Please mark this as ready for review when this can be reviewed again. |
otherwise it would return `Predis\Response\Status`
@dries: I removed $redis->flushdb('ASYNC'); |
This is to fix this issue: #20406
Redis::flushdb()
orCache::flush
does not work currently with predis cluster, this PR fixes that.@tillkruss asked me to mention him