-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Throws an error upon make:policy if no model class is configured #40348
[8.x] Throws an error upon make:policy if no model class is configured #40348
Conversation
@slavicd please provide a thorough explanation in the PR instead of linking to an issue so Taylor knows what this about. Thanks |
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions! If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response. |
@taylorotwell do you have another preference on how to solve this instead? |
Is that an automated comment above, perhaps? @driesvints |
@taylorotwell I need to re-open this or it won't show up in your inbox. |
I'm just going to make it return |
:-D Just like my solution :-) |
If the model config key is not present in
auth.providers.users
themake:policy
command will silently spit out some very poor stub.Fixes: #40345