Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Improvement in the Reflector class. #40241

Merged
merged 1 commit into from
Jan 4, 2022
Merged

[8.x] Improvement in the Reflector class. #40241

merged 1 commit into from
Jan 4, 2022

Conversation

selcukcukur
Copy link
Contributor

Improvement in the Reflector class.

@nunomaduro nunomaduro changed the title [9.x] Improvement in the Reflector class. [8.x] Improvement in the Reflector class. Jan 3, 2022
nunomaduro
nunomaduro approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@GrahamCampbell
Copy link
Member

I find the old code easier to read, and the logic clearer, tbh.

@taylorotwell taylorotwell merged commit 8d745f1 into laravel:8.x Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro nunomaduro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@selcukcukur @GrahamCampbell @nunomaduro @taylorotwell