Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Display exception message with assertRedirect #39841

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

erikgaal
Copy link
Contributor

Extending the functionality of #38025, this PR aims to bring the developer experience improvements from the aforementioned PR when using assertRedirect and derivatives.

I'm not too sure about the wording in the message now, but it is the most accurate, according to the implementation of Symfony\Component\HttpFoundation\Response::isRedirect().

Expected response status code [201, 301, 302, 303, 307, 308] but received 500.

@taylorotwell taylorotwell merged commit abe5a84 into laravel:8.x Dec 1, 2021
@erikgaal erikgaal deleted the patch-assert-redirect branch April 12, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants