[8.x] Add aggregate method to Eloquent passthru #39772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Illuminate\Database\Eloquent\Builder::aggregate(...)
to the list of passthru. This allows aggregations that are not included in the eloquent builder by default (e.g. count, min and max) to be used on the eloquent builder without having to call->toBase()
first.While this is technically breaking, the method is currently unusable so its more of a bugfix. It should not affect anyone as far as I can tell. If you feel it should go to 9.x I'm happy to rebase.
Before:
After:
Edit: I'm also happy to add tests if necessary