[8.x] Don't name unnamed routes inside a group with a prefix #39525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you register an unnamed route within a group with a name prefix, the route's name is set to the prefix.
While the consequences of this are somewhat obscure (but definitely exist), it is indeed odd behavior and I would expect
getName()
to returnnull
in the above example since I never explicitly set a name on the route.This PR attempts to fix that within the constraints of the current architecture. I'm not sure if this would be considered a breaking change vs a bug fix, but I can PR this instead to master if desired.
Basically, instead of passing the group's
$action['as']
value into each new route created within it, it passes it as$action['as_prefix']
. Then when a name is set on a route, it prepends$action['as_prefix']
.This also changes the behavior of calling
name
more than once on a route. Previously each time you called it, the value passed would be continually appended:Now, the value will be appended onto the initial group prefix each time: