Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fifo support for queue name suffix #39497

Merged

Conversation

ArronKing
Copy link
Contributor

PR to add support for fifo naming conventions.

A FIFO SQS queue must always end with .fifo. For example, you set a queue name of emails.fifo and a suffix of -staging you end up with a queue name of emails.fifo-staging. After this PR you get emails-staging.fifo.

I appriciate FIFO queues aren't supported by the Framework. But there are packages that add support. This PR just adds support for the naming convention.

Thanks

@GrahamCampbell
Copy link
Member

I don't think just jamming fifo on a queue is enough. Laravel doesn't understand group ids.

@ArronKing
Copy link
Contributor Author

Yeah I agree, but I'm not trying to add FIFO support. This focused on fixing(?) the naming of fifo queues when using a suffix.

Using a suffix of -production and a FIFO SQS queue with the name emails.fifo. We should end up with the name emails-production.fifo not emails.fifo-production?

If it helps, my use case is I'm using https://github.com/shiftonelabs/laravel-sqs-fifo-queue to add Fifo support. But would still like to use some Laravel queue features, like artisan queue:work and artisan queue:monitor etc. These don't really care if it's a standard queue or fifo queue, but in order for them to work we need the suffix to be in the correct place.

Thanks again

@taylorotwell
Copy link
Member

Thanks for explaining. Will look it over soon.

@GrahamCampbell GrahamCampbell changed the title Fifo support for queue name suffix [8.x] Fifo support for queue name suffix Nov 6, 2021
@taylorotwell taylorotwell merged commit 3282651 into laravel:8.x Nov 7, 2021
@ArronKing ArronKing deleted the feature/fifo-queue-suffix branch November 19, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants