[8.x] MySQL Builds

.github/workflows/databases.yml

@@ -0,0 +1,47 @@
+name: databases
+
+on: [push, pull_request]
+
+jobs:
+  mysql:
+    runs-on: ubuntu-20.04
+
+    services:
+      mysql:
+        image: mysql:5.7
+        env:
+          MYSQL_ALLOW_EMPTY_PASSWORD: yes
+          MYSQL_DATABASE: forge
+        ports:
+          - 3306:3306
+        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
+
+    strategy:
+      fail-fast: true
+
+    name: MySQL 5.7
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.0
+          extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, pdo_mysql
+          tools: composer:v2
+          coverage: none
+
+      - name: Install dependencies
+        uses: nick-invision/retry@v1
+        with:
+          timeout_minutes: 5
+          max_attempts: 5
+          command: composer update --prefer-stable --prefer-dist --no-interaction --no-progress
+
+      - name: Execute tests
+        run: vendor/bin/phpunit tests/Integration/Database --verbose
+        env:
+          DB_CONNECTION: mysql
+          DB_USERNAME: root

tests/Integration/Database/DatabaseMySqlConnectionTest.php

@@ -10,13 +10,20 @@
  * @requires extension pdo_mysql
  * @requires OS Linux|Darwin
  */
-class DatabaseMySqlConnectionTest extends DatabaseMySqlTestCase
+class DatabaseMySqlConnectionTest extends DatabaseTestCase
 {
     const TABLE = 'player';
     const FLOAT_COL = 'float_col';
     const JSON_COL = 'json_col';
     const FLOAT_VAL = 0.2;
 
+    protected function getEnvironmentSetUp($app)
+    {
+        parent::getEnvironmentSetUp($app);
+
+        $app['config']->set('database.default', 'mysql');
+    }
+
     protected function setUp(): void
     {
         parent::setUp();

tests/Integration/Database/DatabaseSchemaBuilderAlterTableWithEnumTest.php → tests/Integration/Database/DatabaseMySqlSchemaBuilderAlterTableWithEnumTest.php

@@ -10,8 +10,15 @@
  * @requires extension pdo_mysql
  * @requires OS Linux|Darwin
  */
-class DatabaseSchemaBuilderAlterTableWithEnumTest extends DatabaseMySqlTestCase
+class DatabaseMySqlSchemaBuilderAlterTableWithEnumTest extends DatabaseTestCase
 {
+    protected function getEnvironmentSetUp($app)
+    {
+        parent::getEnvironmentSetUp($app);
+
+        $app['config']->set('database.default', 'mysql');
+    }
+
     protected function setUp(): void
     {
         parent::setUp();

tests/Integration/Database/DatabaseTestCase.php

@@ -4,18 +4,29 @@
 
 use Orchestra\Testbench\TestCase;
 
-class DatabaseTestCase extends TestCase
+abstract class DatabaseTestCase extends TestCase
 {
     protected function getEnvironmentSetUp($app)
     {
         $app['config']->set('app.debug', 'true');
 
-        $app['config']->set('database.default', 'testbench');
-
         $app['config']->set('database.connections.testbench', [
             'driver' => 'sqlite',
             'database' => ':memory:',
             'prefix' => '',
         ]);
+
+        if (! env('DB_CONNECTION')) {
+            $app['config']->set('database.default', 'testbench');
+        }
+    }
+
+    protected function tearDown(): void
+    {
+        if ($this->app['config']->get('database.default') !== 'testbench') {
+            $this->artisan('db:wipe', ['--drop-views' => true]);
+        }
+
+        parent::tearDown();
     }
 }

tests/Integration/Database/EloquentBelongsToManyTest.php

@@ -48,7 +48,7 @@ protected function setUp(): void
 
         Schema::create('posts_tags', function (Blueprint $table) {
             $table->integer('post_id');
-            $table->integer('tag_id');
+            $table->string('tag_id');
             $table->string('flag')->default('')->nullable();
             $table->timestamps();
         });
@@ -132,7 +132,7 @@ public function testCustomPivotClass()
         $post->tagsWithCustomPivot()->attach($tag->id);
 
         $this->assertInstanceOf(PostTagPivot::class, $post->tagsWithCustomPivot[0]->pivot);
-        $this->assertEquals('1507630210', $post->tagsWithCustomPivot[0]->pivot->getAttributes()['created_at']);
+        $this->assertEquals('1507630210', $post->tagsWithCustomPivot[0]->pivot->created_at);
 
         $this->assertInstanceOf(PostTagPivot::class, $post->tagsWithCustomPivotClass[0]->pivot);
         $this->assertSame('posts_tags', $post->tagsWithCustomPivotClass()->getTable());
@@ -213,8 +213,8 @@ public function testCustomPivotClassUpdatesTimestamps()
         DB::table('posts_tags')->insert([
             [
                 'post_id' => $post->id, 'tag_id' => $tag->id, 'flag' => 'empty',
-                'created_at' => '1507630210',
-                'updated_at' => '1507630210',
+                'created_at' => '2017-10-10 10:10:10',
+                'updated_at' => '2017-10-10 10:10:10',
             ],
         ]);
 
@@ -226,8 +226,8 @@ public function testCustomPivotClassUpdatesTimestamps()
         );
         foreach ($post->tagsWithCustomExtraPivot as $tag) {
             $this->assertSame('exclude', $tag->pivot->flag);
-            $this->assertEquals('1507630210', $tag->pivot->getAttributes()['created_at']);
-            $this->assertEquals('1507630220', $tag->pivot->getAttributes()['updated_at']); // +10 seconds
+            $this->assertEquals('2017-10-10 10:10:10', $tag->pivot->getAttributes()['created_at']);
+            $this->assertEquals('2017-10-10 10:10:20', $tag->pivot->getAttributes()['updated_at']); // +10 seconds
         }
     }
 
@@ -1068,7 +1068,11 @@ class UserPostPivot extends Pivot
 class PostTagPivot extends Pivot
 {
     protected $table = 'posts_tags';
-    protected $dateFormat = 'U';
+
+    public function getCreatedAtAttribute($value)
+    {
+        return Carbon::parse($value)->format('U');
+    }
 }
 
 class TagWithGlobalScope extends Model

tests/Integration/Database/EloquentPrunableTest.php

@@ -111,15 +111,6 @@ public function testPruneWithCustomPruneMethod()
         $this->assertFalse((bool) PrunableWithCustomPruneMethodTestModel::orderBy('id', 'desc')->first()->pruned);
         $this->assertEquals(5000, PrunableWithCustomPruneMethodTestModel::count());
     }
-
-    public function tearDown(): void
-    {
-        parent::tearDown();
-
-        Container::setInstance(null);
-
-        m::close();
-    }
 }
 
 class PrunableTestModel extends Model

tests/Integration/Database/EloquentWhereHasMorphTest.php

@@ -97,9 +97,9 @@ public function testWhereHasMorphWithWildcardAndMorphMap()
         try {
             $comments = Comment::whereHasMorph('commentable', '*', function (Builder $query) {
                 $query->where('title', 'foo');
-            })->get();
+            })->orderBy('id')->get();
 
-            $this->assertEquals([4, 1], $comments->pluck('id')->all());
+            $this->assertEquals([1, 4], $comments->pluck('id')->all());
         } finally {
             Relation::morphMap([], false);
         }

tests/Integration/Database/EloquentWithCountTest.php

@@ -67,9 +67,10 @@ public function testSortingScopes()
         $one = Model1::create();
         $one->twos()->create();
 
-        $result = Model1::withCount('twos')->toSql();
+        $query = Model1::withCount('twos')->getQuery();
 
-        $this->assertSame('select "one".*, (select count(*) from "two" where "one"."id" = "two"."one_id") as "twos_count" from "one"', $result);
+        $this->assertNull($query->orders);
+        $this->assertSame([], $query->getRawBindings()['order']);
     }
 }
 

tests/Integration/Database/QueryBuilderTest.php

@@ -101,7 +101,7 @@ public function testAddSelectWithSubQuery()
 
     public function testFromWithAlias()
     {
-        $this->assertSame('select * from "posts" as "alias"', DB::table('posts', 'alias')->toSql());
+        $this->assertCount(2, DB::table('posts', 'alias')->select('alias.*'));
     }
 
     public function testFromWithSubQuery()

tests/Integration/Database/SchemaBuilderTest.php

@@ -31,11 +31,11 @@ public function testDropAllViews()
     {
         $this->expectNotToPerformAssertions();
 
-        DB::statement('create view "view"("id") as select 1');
+        DB::statement('create view foo (id) as select 1');
 
         Schema::dropAllViews();
 
-        DB::statement('create view "view"("id") as select 1');
+        DB::statement('create view foo (id) as select 1');
     }
 
     public function testRegisterCustomDoctrineType()
@@ -50,20 +50,9 @@ public function testRegisterCustomDoctrineType()
             $table->tinyInteger('test_column')->change();
         });
 
-        $expected = [
-            'CREATE TEMPORARY TABLE __temp__test AS SELECT test_column FROM test',
-            'DROP TABLE test',
-            'CREATE TABLE test (test_column TINYINT NOT NULL)',
-            'INSERT INTO test (test_column) SELECT test_column FROM __temp__test',
-            'DROP TABLE __temp__test',
-        ];
-
-        $statements = $blueprint->toSql($this->getConnection(), new SQLiteGrammar);
-
         $blueprint->build($this->getConnection(), new SQLiteGrammar);
 
         $this->assertArrayHasKey(TinyInteger::NAME, Type::getTypesMap());
         $this->assertSame('tinyinteger', Schema::getColumnType('test', 'test_column'));
-        $this->assertEquals($expected, $statements);
     }
 }