[8.x] Make accept header comparison case-insensitive #39413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe change the RFC link since that one is for MIME :) The one for Accept header is at https://datatracker.ietf.org/doc/html/rfc7231#section-5.3.1. |
GrahamCampbell
changed the title
kunalray1993
deleted the
feat/request-accepts-method-case-insensitive-checking
branch
chu121su12
pushed a commit
to chu121su12/framework
that referenced
this pull request
Oct 30, 2021
* Make accept header comparison case-insensitive * Update comment and ref link * Update InteractsWithContentTypes.php Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for the issue mentioned in the #39411, that the
$request->acceptsmethod is currently allowing only case sensitive checking.This pull request will convert both variables to lowercase before making the comparison. By doing so, the
APPLICATION/JSONorAPPLICATION/*header can match with any letter case in the code.The new test method is added to the
\Illuminate\Tests\Http\HttpRequestTestclass for case-insensitive test.