[8.x] Improve content negotiation for exception handling #39385
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to the rejected PR #39361 which was incorrectly (my bad 🤦 ) only targeting
AuthenticationException
(pointed out by Taylor here).This PR is almost identical but with two important changes:
shouldReturnJson()
for all exceptions (done so in the main functionrender()
but also in the protected functions called by this method).shouldReturnJson
method so that more complex logic can be performed by overriding this simple method. Requested by Taylor Otwell hereThe new possibilities added by this PR is as already explained in PR #39361:
I would consider this PR as a non-breaking change since it merely extracts logic into a new method, but will let Dries and Graham discuss semantics about the proper definition of "non-breaking change" 😄
p.s. I was not able to edit PR #39361 hence this new PR - I apologize if it is in fact possible to edit a rejected PR (please share info about how this is done if anyone holds this info 👍 )