-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Add nested relationships to whereRelation function #39064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josemariagomez
changed the title
Add nested relationships to whereRelation function
[8.x] Add nested relationships to whereRelation function
Oct 2, 2021
driesvints
requested changes
Oct 4, 2021
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
Outdated
Show resolved
Hide resolved
Why was this merged?
|
taylorotwell
pushed a commit
that referenced
this pull request
Oct 7, 2021
chu121su12
pushed a commit
to chu121su12/framework
that referenced
this pull request
Oct 7, 2021
laravel#39064)" (laravel#39130) * Revert "[8.x] Add nested relationships to whereRelation function (laravel#39064)" This reverts commit bc92a96. * Add tests for nested whereRelation queries
chu121su12
pushed a commit
to chu121su12/framework
that referenced
this pull request
Oct 8, 2021
* Add nested relationships to whereRelation function * Removed 2 spaces * formatting * Update QueriesRelationships.php Co-authored-by: Jose María Gómez Martín <[email protected]> Co-authored-by: Taylor Otwell <[email protected]>
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
* Add nested relationships to whereRelation function * Removed 2 spaces * formatting * Update QueriesRelationships.php Co-authored-by: Jose María Gómez Martín <[email protected]> Co-authored-by: Taylor Otwell <[email protected]>
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
laravel#39064)" (laravel#39130) * Revert "[8.x] Add nested relationships to whereRelation function (laravel#39064)" This reverts commit bc92a96. * Add tests for nested whereRelation queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added the possibility to use nested relationships when using 'whereRelation' Eloquent's function, using dot notation.
Also still works with not nested relationships, so it's not a breaking change.
How it works